cbfc6fe97f
Since we simplified `tsconfig.base.json`'s `compilerOptions` to not include values that match defaults (as per Jake's feedback), the logic to detect TS solution setup should check that `declaration` is explicitly set to `false`, rather than that it is falsy. Clean up PR: https://github.com/nrwl/nx/pull/29550 <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> We're not detecting TS solution setup correctly ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Detection works ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
{{links}}
Nx: Smart Monorepos · Fast CI
Nx is a build system, optimized for monorepos, with plugins for popular frameworks and tools and advanced CI capabilities including caching and distribution.
This package is a JavaScript/TypeScript plugin for Nx.
{{content}}