cerxes/babel
3
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Adds note about two approval policy to PR template (#10313)

Browse Source 
* Adds note about two approval policy to PR template

* Adds qualifier to approval policy

Because, although two approvals is the general case, some PRs maybe merged with more or fewer approvals

[skip ci]
This commit is contained in:
Thiago Arrais 2019-08-12 12:32:31 -03:00 committed by Nicolò Ribaudo
parent 15535cf52c
commit ee397ff107
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/PULL_REQUEST_TEMPLATE.md vendored
View File

@ -2,6 +2,8 @@
Before making a PR, please read our contributing guidelines Before making a PR, please read our contributing guidelines
https://github.com/babel/babel/blob/master/CONTRIBUTING.md https://github.com/babel/babel/blob/master/CONTRIBUTING.md
Please note that the Babel Team requires two approvals before merging most PRs.
For issue references: Add a comma-separated list of a [closing word](https://help.github.com/articles/closing-issues-via-commit-messages/) followed by the ticket number fixed by the PR. (it should be underlined in the preview if done correctly) For issue references: Add a comma-separated list of a [closing word](https://help.github.com/articles/closing-issues-via-commit-messages/) followed by the ticket number fixed by the PR. (it should be underlined in the preview if done correctly)
If you are making a change that should have a docs update: submit another PR to https://github.com/babel/website If you are making a change that should have a docs update: submit another PR to https://github.com/babel/website