v2.7.3

CHANGELOG.md

@@ -11,12 +11,25 @@
 
 _Note: Gaps between patch versions are faulty/broken releases._
 
+## 2.7.3
+
+ * **Polish**
+  * Indent and add newlines to `React.createElement` calls in `react` transformer.
+  * Remove `Object.assign` calls and replace it with an `extends` helper.
+
+## 2.7.1
+
+ * **New Feature**
+  * Expose `version` on browser and node API.
+ * **Internal**
+  * Upgrade `core-js` to 0.4.1
+
 ## 2.7.0
 
  * **Spec Compliancy**
   * Disallow reassignments of imports.
  * **New Feature**
-  * `reactCompat` to enable pre-v0.12 react components.
+  * `reactCompat` option to enable pre-v0.12 react components.
 
 ## 2.6.3
 

Makefile

@@ -53,7 +53,7 @@ test-cov:
 	node $(ISTANBUL_CMD) $(MOCHA_CMD) --
 
 test-travis: bootstrap
-	$(MOCHA_CMD)
+	node $(ISTANBUL_CMD) $(MOCHA_CMD) --
 	if test -n "$$CODECLIMATE_REPO_TOKEN"; then codeclimate < coverage/lcov.info; fi
 
 test-browser:

lib/6to5/browser.js

@@ -1,5 +1,7 @@
 var transform = module.exports = require("./transformation/transform");
 
+transform.version = require("../../package").version;
+
 transform.transform = transform;
 
 transform.run = function (code, opts) {

lib/6to5/file.js

@@ -35,7 +35,8 @@ File.helpers = [
   "async-to-generator",
   "interop-require-wildcard",
   "typeof",
-  "exports-wildcard"
+  "exports-wildcard",
+  "extends"
 ];
 
 File.excludeHelpersFromRuntime = [
@@ -48,6 +49,7 @@ File.normaliseOptions = function (opts) {
 
   _.defaults(opts, {
     experimental: false,
+    reactCompat:  false,
     playground:   false,
     whitespace:   true,
     moduleIds:    opts.amdModuleIds || false,

lib/6to5/generation/generators/expressions.js

@@ -57,8 +57,28 @@ exports.ThisExpression = function () {
 
 exports.CallExpression = function (node, print) {
   print(node.callee);
+
   this.push("(");
-  print.join(node.arguments, { separator: ", " });
+
+  var separator = ",";
+
+  if (node._prettyPrint) {
+    separator += "\n";
+    this.newline();
+    this.indent();
+  } else {
+    separator += " ";
+  }
+
+  print.join(node.arguments, {
+    separator: separator
+  });
+
+  if (node._prettyPrint) {
+    this.newline();
+    this.dedent();
+  }
+
   this.push(")");
 };
 

lib/6to5/index.js

@@ -3,6 +3,8 @@ var util      = require("./util");
 var fs        = require("fs");
 var _         = require("lodash");
 
+exports.version = require("../../package").version;
+
 exports.types = require("./types");
 
 exports.runtime = require("./runtime-generator");

lib/6to5/transformation/modules/_default.js

@@ -13,7 +13,7 @@ function DefaultFormatter(file) {
 
   this.remapAssignments();
 
-  this.checkCollisions();
+  //this.checkCollisions();
 }
 
 DefaultFormatter.prototype.getLocalExports = function () {
@@ -161,6 +161,9 @@ DefaultFormatter.prototype.getModuleName = function () {
 
   moduleName += filenameRelative;
 
+  // normalise path separators
+  moduleName = moduleName.replace(/\\/g, "/");
+
   return moduleName;
 };
 

lib/6to5/transformation/modules/common.js

@@ -83,10 +83,12 @@ CommonJSFormatter.prototype.exportDeclaration = function (node, nodes) {
       // this export isn't a function so we can't hoist it to the top so we need to set it
       // at the very end of the file with something like:
       //
-      //   module.exports = Object.assign(exports["default"], exports)
+      //   module.exports = _extends(exports["default"], exports)
       //
 
-      assign = util.template("common-export-default-assign", true);
+      assign = util.template("common-export-default-assign", {
+        EXTENDS_HELPER: this.file.addHelper("extends")
+      }, true);
       assign._blockHoist = 0;
 
       nodes.push(assign);

lib/6to5/transformation/templates/common-export-default-assign.js

@@ -1 +1 @@
-module.exports = Object.assign(exports["default"], exports);
+module.exports = EXTENDS_HELPER(exports["default"], exports);

lib/6to5/transformation/templates/extends.js

@@ -0,0 +1,9 @@
+(function (target) {
+  for (var i = 1; i < arguments.length; i++) {
+    var source = arguments[i];
+    for (var key in source) {
+      target[key] = source[key];
+    }
+  }
+  return target;
+})

lib/6to5/transformation/transform.js

@@ -39,6 +39,8 @@ transform.moduleFormatters = {
 };
 
 _.each({
+  specNoForInOfAssignment:   require("./transformers/spec-no-for-in-of-assignment"),
+
   // playground
   methodBinding:             require("./transformers/playground-method-binding"),
   memoizationOperator:       require("./transformers/playground-memoization-operator"),

lib/6to5/transformation/transformers/es7-object-spread.js

@@ -4,7 +4,7 @@ var t = require("../../types");
 
 exports.experimental = true;
 
-exports.ObjectExpression = function (node) {
+exports.ObjectExpression = function (node, parent, file) {
   var hasSpread = false;
   var i;
   var prop;
@@ -42,5 +42,5 @@ exports.ObjectExpression = function (node) {
     args.unshift(t.objectExpression([]));
   }
 
-  return t.callExpression(t.memberExpression(t.identifier("Object"), t.identifier("assign")), args);
+  return t.callExpression(file.addHelper("extends"), args);
 };

lib/6to5/transformation/transformers/optional-proto-to-assign.js

@@ -1,8 +1,6 @@
 var t = require("../../types");
 var _ = require("lodash");
 
-var OBJECT_ASSIGN_MEMBER = t.memberExpression(t.identifier("Object"), t.identifier("assign"));
-
 var isProtoKey = function (node) {
   return t.isLiteral(t.toComputedKey(node, node.key), { value: "__proto__" });
 };
@@ -43,7 +41,7 @@ exports.ExpressionStatement = function (node, parent, file) {
   }
 };
 
-exports.ObjectExpression = function (node) {
+exports.ObjectExpression = function (node, parent, file) {
   var proto;
 
   for (var i in node.properties) {
@@ -58,6 +56,6 @@ exports.ObjectExpression = function (node) {
   if (proto) {
     var args = [t.objectExpression([]), proto];
     if (node.properties.length) args.push(node);
-    return t.callExpression(OBJECT_ASSIGN_MEMBER, args);
+    return t.callExpression(file.addHelper("extends"), args);
   }
 };

lib/6to5/transformation/transformers/react.js

@@ -32,7 +32,7 @@ exports.XJSExpressionContainer = function (node) {
 exports.XJSAttribute = {
   exit: function (node) {
     var value = node.value || t.literal(true);
-    return t.property("init", node.name, value);
+    return t.inherits(t.property("init", node.name, value), node);
   }
 };
 
@@ -42,7 +42,7 @@ var isTag = function(tagName) {
 
 exports.XJSOpeningElement = {
   exit: function (node, parent, file) {
-    var reactCompat = file.opts && file.opts.reactCompat;
+    var reactCompat = file.opts.reactCompat;
     var tagExpr = node.name;
     var args = [];
 
@@ -107,25 +107,17 @@ exports.XJSOpeningElement = {
       if (tagName && isTag(tagName)) {
         return t.callExpression(
           t.memberExpression(
-            t.memberExpression(
-              t.identifier('React'),
-              t.identifier('DOM'),
-              false
-            ),
+            t.memberExpression(t.identifier("React"), t.identifier("DOM")),
             tagExpr,
             t.isLiteral(tagExpr)
           ),
           args
         );
-      } else {
-        return t.callExpression(
-          tagExpr,
-          args
-        );
       }
+    } else {
+      tagExpr = t.memberExpression(t.identifier("React"), t.identifier("createElement"));
     }
 
-    tagExpr = t.memberExpression(t.identifier("React"), t.identifier("createElement"));
     return t.callExpression(tagExpr, args);
   }
 };
@@ -148,16 +140,16 @@ exports.XJSElement = {
           var isLastLine = +i === lines.length - 1;
 
           // replace rendered whitespace tabs with spaces
-          var trimmedLine = line.replace(/\t/g, ' ');
+          var trimmedLine = line.replace(/\t/g, " ");
 
           // trim whitespace touching a newline
           if (!isFirstLine) {
-            trimmedLine = trimmedLine.replace(/^[ ]+/, '');
+            trimmedLine = trimmedLine.replace(/^[ ]+/, "");
           }
 
           // trim whitespace touching an endline
           if (!isLastLine) {
-            trimmedLine = trimmedLine.replace(/[ ]+$/, '');
+            trimmedLine = trimmedLine.replace(/[ ]+$/, "");
           }
 
           if (trimmedLine) {
@@ -173,6 +165,10 @@ exports.XJSElement = {
       callExpr.arguments.push(child);
     }
 
+    if (callExpr.arguments.length >= 3) {
+      callExpr._prettyPrint = true;
+    }
+
     return t.inherits(callExpr, node);
   }
 };

lib/6to5/transformation/transformers/spec-no-for-in-of-assignment.js

@@ -0,0 +1,10 @@
+var t = require("../../types");
+
+exports.ForInStatement =
+exports.ForOfStatement = function (node, parent, file) {
+  var left = node.left;
+  if (t.isVariableDeclaration(left)) {
+    var declar = left.declarations[0];
+    if (declar.init) throw file.errorWithNode(declar, "No assignments allowed in for-in/of head");
+  }
+};

lib/6to5/util.js

@@ -146,10 +146,10 @@ exports.template = function (name, nodes, keepExpression) {
   var node = template.body[0];
 
   if (!keepExpression && t.isExpressionStatement(node)) {
-    node = node.expression;
+    return node.expression;
+  } else {
+    return node;
   }
-
-  return node;
 };
 
 exports.codeFrame = function (lines, lineNumber, colNumber) {

package.json

@@ -1,7 +1,7 @@
 {
   "name": "6to5",
   "description": "Turn ES6 code into readable vanilla ES5 with source maps",
-  "version": "2.7.0",
+  "version": "2.7.3",
   "author": "Sebastian McKenzie <sebmck@gmail.com>",
   "homepage": "https://github.com/6to5/6to5",
   "repository": {
@@ -43,7 +43,7 @@
     "ast-types": "~0.6.1",
     "chokidar": "0.11.1",
     "commander": "2.5.0",
-    "core-js": "^0.4.0",
+    "core-js": "^0.4.1",
     "estraverse": "1.8.0",
     "esutils": "1.1.6",
     "esvalid": "^1.1.0",

test/fixtures/transformation/es6-modules-common/exports-default-non-function/expected.js

@@ -1,6 +1,17 @@
 "use strict";
 
+var _extends = function (target) {
+  for (var i = 1; i < arguments.length; i++) {
+    var source = arguments[i];
+    for (var key in source) {
+      target[key] = source[key];
+    }
+  }
+
+  return target;
+};
+
 exports.Cachier = Cachier;
 exports["default"] = new Cachier();
 function Cachier(databaseName) {}
-module.exports = Object.assign(exports["default"], exports);
+module.exports = _extends(exports["default"], exports);

test/fixtures/transformation/es7-object-spread/assignment/expected.js

@@ -1,3 +1,14 @@
 "use strict";
 
-z = Object.assign({ x: x }, y);
+var _extends = function (target) {
+  for (var i = 1; i < arguments.length; i++) {
+    var source = arguments[i];
+    for (var key in source) {
+      target[key] = source[key];
+    }
+  }
+
+  return target;
+};
+
+z = _extends({ x: x }, y);

test/fixtures/transformation/es7-object-spread/expression/expected.js

@@ -1,3 +1,14 @@
 "use strict";
 
-Object.assign({ x: x }, y, { a: a }, b, { c: c });
+var _extends = function (target) {
+  for (var i = 1; i < arguments.length; i++) {
+    var source = arguments[i];
+    for (var key in source) {
+      target[key] = source[key];
+    }
+  }
+
+  return target;
+};
+
+_extends({ x: x }, y, { a: a }, b, { c: c });

test/fixtures/transformation/es7-object-spread/variable-declaration/expected.js

@@ -1,3 +1,14 @@
 "use strict";
 
-var z = Object.assign({}, x);
+var _extends = function (target) {
+  for (var i = 1; i < arguments.length; i++) {
+    var source = arguments[i];
+    for (var key in source) {
+      target[key] = source[key];
+    }
+  }
+
+  return target;
+};
+
+var z = _extends({}, x);

test/fixtures/transformation/optional-core-aliasing/es7-object-spread-rest/actual.js

@@ -1 +0,0 @@
-var z = { ...x };

test/fixtures/transformation/optional-core-aliasing/es7-object-spread-rest/expected.js

@@ -1,9 +0,0 @@
-"use strict";
-
-var _interopRequire = function (obj) {
-  return obj && (obj["default"] || obj);
-};
-
-var _core = _interopRequire(require("core-js/library"));
-
-var z = _core.Object.assign({}, x);

test/fixtures/transformation/optional-proto-to-assign/object-literal/expected.js

@@ -1,10 +1,21 @@
 "use strict";
 
-var foo = Object.assign({}, bar);
+var _extends = function (target) {
+  for (var i = 1; i < arguments.length; i++) {
+    var source = arguments[i];
+    for (var key in source) {
+      target[key] = source[key];
+    }
+  }
 
-var foo = Object.assign({}, bar, {
+  return target;
+};
+
+var foo = _extends({}, bar);
+
+var foo = _extends({}, bar, {
   bar: "foo" });
 
-var foo = Object.assign({}, bar, {
+var foo = _extends({}, bar, {
   bar: "foo"
 });

test/fixtures/transformation/react/adds-appropriate-newlines-when-using-spread-attribute/expected.js

@@ -1,3 +1,2 @@
 React.createElement(Component, React.__spread({}, this.props, {
-  sound: "moo"
-}));
+  sound: "moo" }));

test/fixtures/transformation/react/compat-convert-component/expected.js

@@ -1,3 +1 @@
-var x = Component({
-  foo: "bar"
-}, Namespace.Component(null));
+var x = Component({ foo: "bar" }, Namespace.Component(null));

test/fixtures/transformation/react/compat-convert-tags/expected.js

@@ -1,3 +1 @@
-var x = React.DOM.div({
-  foo: "bar"
-}, React.DOM["font-face"](null));
+var x = React.DOM.div({ foo: "bar" }, React.DOM["font-face"](null));

test/fixtures/transformation/react/should-allow-constructor-as-prop/expected.js

@@ -1,3 +1 @@
-React.createElement(Component, {
-  constructor: "foo"
-});
+React.createElement(Component, { constructor: "foo" });

test/fixtures/transformation/react/should-avoid-wrapping-in-extra-parens-if-not-needed/expected.js

@@ -1,7 +1,23 @@
-var x = React.createElement("div", null, React.createElement(Component, null));
+var x = React.createElement(
+  "div",
+  null,
+  React.createElement(Component, null)
+);
 
-var x = React.createElement("div", null, this.props.children);
+var x = React.createElement(
+  "div",
+  null,
+  this.props.children
+);
 
-var x = React.createElement(Composite, null, this.props.children);
+var x = React.createElement(
+  Composite,
+  null,
+  this.props.children
+);
 
-var x = React.createElement(Composite, null, React.createElement(Composite2, null));
+var x = React.createElement(
+  Composite,
+  null,
+  React.createElement(Composite2, null)
+);

test/fixtures/transformation/react/should-convert-simple-text/expected.js

@@ -1 +1,5 @@
-var x = React.createElement("div", null, "text");
+var x = React.createElement(
+  "div",
+  null,
+  "text"
+);

test/fixtures/transformation/react/should-handle-has-own-property-correctly/expected.js

@@ -1 +1,5 @@
-React.createElement("hasOwnProperty", null, "testing");
+React.createElement(
+  "hasOwnProperty",
+  null,
+  "testing"
+);

test/fixtures/transformation/react/should-have-correct-comma-in-nested-children/expected.js

@@ -1 +1,17 @@
-var x = React.createElement("div", null, React.createElement("div", null, React.createElement("br", null)), React.createElement(Component, null, foo, React.createElement("br", null), bar), React.createElement("br", null));
+var x = React.createElement(
+  "div",
+  null,
+  React.createElement(
+    "div",
+    null,
+    React.createElement("br", null)
+  ),
+  React.createElement(
+    Component,
+    null,
+    foo,
+    React.createElement("br", null),
+    bar
+  ),
+  React.createElement("br", null)
+);

test/fixtures/transformation/react/should-insert-commas-after-expressions-before-whitespace/expected.js

@@ -2,5 +2,4 @@ var x = React.createElement("div", {
   attr1: "foo" + "bar",
   attr2: "foo" + "bar" + "baz" + "bug",
   attr3: "foo" + "bar" + "baz" + "bug",
-  attr4: "baz"
-});
+  attr4: "baz" });

test/fixtures/transformation/react/wraps-props-in-react-spread-for-first-spread-attributes/expected.js

@@ -1,4 +1 @@
-React.createElement(Component, React.__spread({}, x, {
-  y: 2,
-  z: true
-}));
+React.createElement(Component, React.__spread({}, x, { y: 2, z: true }));

test/fixtures/transformation/react/wraps-props-in-react-spread-for-last-spread-attributes/expected.js

@@ -1,4 +1 @@
-React.createElement(Component, React.__spread({
-  y: 2,
-  z: true
-}, x));
+React.createElement(Component, React.__spread({ y: 2, z: true }, x));

test/fixtures/transformation/react/wraps-props-in-react-spread-for-middle-spread-attributes/expected.js

@@ -1,5 +1 @@
-React.createElement(Component, React.__spread({
-  y: 2
-}, x, {
-  z: true
-}));
+React.createElement(Component, React.__spread({ y: 2 }, x, { z: true }));

test/fixtures/transformation/spec/for-in-assignment/actual.js

@@ -0,0 +1,3 @@
+for (var i = 0 in obj) {
+
+}

test/fixtures/transformation/spec/for-in-assignment/options.json

@@ -0,0 +1,3 @@
+{
+  "throws": "No assignments allowed in for-in/of head"
+}

test/fixtures/transformation/spec/for-of-assignment/actual.js

@@ -0,0 +1,3 @@
+for (var i = 0 of obj) {
+
+}

test/fixtures/transformation/spec/for-of-assignment/options.json

@@ -0,0 +1,3 @@
+{
+  "throws": "No assignments allowed in for-in/of head"
+}