v3.0.11

CHANGELOG.md

@@ -11,6 +11,46 @@
 
 _Note: Gaps between patch versions are faulty/broken releases._
 
+## 3.0.11
+
+ * **Bug Fix**
+  * Fix `ast-types` `RestElement` definition.
+  * Make `es6.forOf` loose mode more versatile and support destructuring.
+
+## 3.0.10
+
+ * **Bug Fix**
+  * In `types.getIds` make sure the `declaration` inside of `ExportDeclaration` is actually a `Declaration`.
+
+## 3.0.9
+
+ * **Bug Fix**
+  * Make `t.isReferenced` more powerful, actually take into consideration all contexts were identifier nodes aren't actually references.
+  * Don't camelcase underscores when converting a string to a valid identifier.
+
+## 3.0.8
+
+ * **Bug Fix**
+  * Split up default function declaration exports due to regenerator destroying the parent export declaration.
+
+## 3.0.7
+
+ * **Internal**
+  * Upgrade `core-js` to `0.4.9`.
+ * **Bug Fix**
+  * Add id to function express scope tracking.
+
+## 3.0.6
+
+ * **Bug Fix**
+  * Fix block scope variable tracking stopping whenever it hits a new scope.
+  * Fix block scope variable tracking breaking on all block statement scopes that have a for loop parent.
+
+## 3.0.5
+
+ * **Internal**
+  * More reliable default parameter scope.
+
 ## 3.0.4
 
  * **Bug Fix**

lib/6to5/file.js

@@ -325,7 +325,7 @@ File.prototype.transform = function (ast) {
 
   this.ast = ast;
   this.lastStatements = t.getLastStatements(ast.program);
-  this.scope = new Scope(ast.program, null, this);
+  this.scope = new Scope(ast.program, ast, null, this);
   this.moduleFormatter = this.getModuleFormatter(this.opts.modules);
 
   var astRun = function (key) {

lib/6to5/patch.js

@@ -34,9 +34,9 @@ def("ImportBatchSpecifier")
   .field("name", def("Identifier"));
 
 def("RestElement")
-  .bases("Node")
+  .bases("Pattern")
   .build("argument")
-  .field("argument", def("Pattern"));
+  .field("argument", def("expression"));
 
 // Abstract references
 def("VirtualPropertyExpression")

lib/6to5/transformation/templates/for-of-loose.js

@@ -2,6 +2,7 @@ for (var LOOP_OBJECT = OBJECT,
          IS_ARRAY = Array.isArray(LOOP_OBJECT),
          INDEX = 0,
          LOOP_OBJECT = IS_ARRAY ? LOOP_OBJECT : LOOP_OBJECT[Symbol.iterator]();;) {
+  var ID;
   if (IS_ARRAY) {
     if (INDEX >= LOOP_OBJECT.length) break;
     ID = LOOP_OBJECT[INDEX++];

lib/6to5/transformation/transformers/es6/for-of.js

@@ -20,11 +20,7 @@ exports.ForOfStatement = function (node, parent, scope, context, file) {
 
   // add the value declaration to the new loop body
   if (declar) {
-    if (build.shouldUnshift) {
-      block.body.unshift(declar);
-    } else {
-      block.body.push(declar);
-    }
+    block.body.push(declar);
   }
 
   // push the rest of the original loop body onto our new body
@@ -45,9 +41,9 @@ var loose = function (node, parent, scope, context, file) {
     id = left;
   } else if (t.isVariableDeclaration(left)) {
     // for (var i of test)
-    id = left.declarations[0].id;
+    id = scope.generateUidIdentifier("ref");
     declar = t.variableDeclaration(left.kind, [
-      t.variableDeclarator(id)
+      t.variableDeclarator(left.declarations[0].id, id)
     ]);
   } else {
     throw file.errorWithNode(left, "Unknown node type " + left.type + " in ForOfStatement");
@@ -61,10 +57,15 @@ var loose = function (node, parent, scope, context, file) {
     ID:           id
   });
 
+  if (!declar) {
+    // no declaration so we need to remove the variable declaration at the top of
+    // the for-of-loose template
+    loop.body.body.shift();
+  }
+
   return {
-    shouldUnshift: true,
-    declar:        declar,
-    loop:          loop
+    declar: declar,
+    loop:   loop
   };
 };
 

lib/6to5/transformation/transformers/es6/parameters.default.js

@@ -1,7 +1,8 @@
 "use strict";
 
-var util = require("../../../util");
-var t    = require("../../../types");
+var traverse = require("../../../traverse");
+var util     = require("../../../util");
+var t        = require("../../../types");
 
 var hasDefaults = function (node) {
   for (var i = 0; i < node.params.length; i++) {
@@ -10,12 +11,20 @@ var hasDefaults = function (node) {
   return false;
 };
 
+var iifeVisitor = {
+  enter: function (node, parent, scope, context, state) {
+    if (t.isReferencedIdentifier(node, parent) && scope.hasOwn(node.name)) {
+      state.iife = true;
+      context.stop();
+    }
+  }
+};
+
 exports.Function = function (node, parent, scope) {
   if (!hasDefaults(node)) return;
 
   t.ensureBlock(node);
 
-  var iife = false;
   var body = [];
 
   var argsIdentifier = t.identifier("arguments");
@@ -23,6 +32,8 @@ exports.Function = function (node, parent, scope) {
 
   var lastNonDefaultParam = 0;
 
+  var state = { iife: false, scope: scope };
+
   for (var i = 0; i < node.params.length; i++) {
     var param = node.params[i];
 
@@ -36,10 +47,12 @@ exports.Function = function (node, parent, scope) {
 
     node.params[i] = scope.generateUidIdentifier("x");
 
-    // we're accessing a variable that's already defined within this function
-    var localDeclar = scope.get(left.name, true);
-    if (localDeclar !== left) {
-      iife = true;
+    if (!state.iife) {
+      if (t.isIdentifier(right) && scope.hasOwn(right.name)) {
+        state.iife = true;
+      } else {
+        traverse(right, iifeVisitor, scope, state);
+      }
     }
 
     var defNode = util.template("default-parameter", {
@@ -55,7 +68,7 @@ exports.Function = function (node, parent, scope) {
   // we need to cut off all trailing default parameters
   node.params = node.params.slice(0, lastNonDefaultParam);
 
-  if (iife) {
+  if (state.iife) {
     var container = t.functionExpression(null, [], node.body, node.generator);
     container._aliasFunction = true;
 

lib/6to5/transformation/transformers/es6/parameters.rest.js

@@ -12,8 +12,6 @@ exports.Function = function (node, parent, scope) {
 
   var rest = node.params.pop().argument;
 
-  t.ensureBlock(node);
-
   var argsId = t.identifier("arguments");
 
   // otherwise `arguments` will be remapped in arrow functions

lib/6to5/transformation/transformers/index.js

@@ -58,6 +58,7 @@ module.exports = {
   "es6.parameters.default":                require("./es6/parameters.default"),
   "es6.parameters.rest":                   require("./es6/parameters.rest"),
 
+  // needs to be before regenerator since regenerator doesn't know how to handle destructuring patterns
   "es6.destructuring":                     require("./es6/destructuring"),
 
   // needs to be after `regenerator` due to needing `regeneratorRuntime` references

lib/6to5/transformation/transformers/internal/modules-split.js

@@ -1,5 +1,11 @@
 "use strict";
 
+// in this transformer we have to split up classes and function declarations
+// from their exports. why? because sometimes we need to replace classes with
+// nodes that aren't allowed in the same contexts. also, if you're exporting
+// a generator function as a default then regenerator will destroy the export
+// declaration and leave a variable declaration in it's place... yeah, handy.
+
 var t = require("../../../types");
 
 exports.ExportDeclaration = function (node, parent, scope) {
@@ -16,6 +22,10 @@ exports.ExportDeclaration = function (node, parent, scope) {
       ]);
       node.declaration = temp;
       return [declar, node];
+    } else if (t.isFunctionDeclaration(declar)) {
+      node._blockHoist = 2;
+      node.declaration = declar.id;
+      return [declar, node];
     }
   } else {
     if (t.isFunctionDeclaration(declar)) {

lib/6to5/traverse/index.js

@@ -111,7 +111,7 @@ TraversalContext.prototype.visitNode = function (obj, key, opts, scope, parent,
   var ourScope = scope;
   // we're entering a new scope so let's construct it!
   if (t.isScope(node)) {
-    ourScope = new Scope(node, scope);
+    ourScope = new Scope(node, parent, scope);
   }
 
   node = this.enterNode(obj, key, node, opts.enter, parent, ourScope, state);

lib/6to5/traverse/scope.js

@@ -14,15 +14,18 @@ var FOR_KEYS = ["left", "init"];
  * within.
  *
  * @param {Node} block
+ * @param {Node} parentBlock
  * @param {Scope} [parent]
  * @param {File} [file]
  */
 
-function Scope(block, parent, file) {
+function Scope(block, parentBlock, parent, file) {
   this.parent = parent;
-  this.block  = block;
   this.file   = parent ? parent.file : file;
 
+  this.parentBlock = parentBlock;
+  this.block       = block;
+
   var info = this.getInfo();
   this.references = info.references;
   this.declarations = info.declarations;
@@ -171,7 +174,7 @@ var blockVariableVisitor = {
     if (t.isBlockScoped(node)) {
       add(node, false, t.isLet(node));
     } else if (t.isScope(node)) {
-      context.stop();
+      context.skip();
     }
   }
 };
@@ -196,7 +199,8 @@ Scope.prototype.getInfo = function () {
     }
   };
 
-  if (parent && t.isBlockStatement(block) && t.isFor(parent.block)) {
+  if (parent && t.isBlockStatement(block) && t.isFor(parent.block, { body: block })) {
+    // delegate block let declarations to the parent loop
     return info;
   }
 
@@ -240,6 +244,14 @@ Scope.prototype.getInfo = function () {
     });
   }
 
+  if (t.isFunctionExpression(block) && block.id) {
+    if (!t.isProperty(this.parentBlock, { method: true })) {
+      // SpiderMonkey AST doesn't use MethodDefinition here when it probably
+      // should since they should be semantically the same?
+      add(block.id);
+    }
+  }
+
   // Program
 
   if (t.isProgram(block)) {

lib/6to5/types/index.js

@@ -2,6 +2,7 @@
 
 var toFastProperties = require("../helpers/to-fast-properties");
 var esutils          = require("esutils");
+var object           = require("../helpers/object");
 var Node             = require("./node");
 var _                = require("lodash");
 
@@ -225,7 +226,7 @@ t.prependToMemberExpression = function (member, append) {
 };
 
 /**
- * Description
+ * Check if the input `node` is a reference to a bound variable.
  *
  * @param {Object} node
  * @param {Object} parent
@@ -233,45 +234,94 @@ t.prependToMemberExpression = function (member, append) {
  */
 
 t.isReferenced = function (node, parent) {
-  // we're a property key and we aren't computed so we aren't referenced
-  if (t.isProperty(parent) && parent.key === node && !parent.computed) return false;
-
-  if (t.isFunction(parent)) {
-    // we're a function param
-    if (_.contains(parent.params, node)) return false;
-
-    for (var i = 0; i < parent.params.length; i++) {
-      var param = parent.params[i];
-      if (param === node) {
-        return false;
-      } else if (t.isRestElement(param) && param.argument === node) {
-        return false;
-      }
+  // yes: PARENT[NODE]
+  // yes: NODE.child
+  // no: parent.CHILD
+  if (t.isMemberExpression(parent)) {
+    if (parent.property === node && parent.computed) {
+      return true;
+    } else if (parent.object === node) {
+      return true;
+    } else {
+      return false;
     }
   }
 
-  if (t.isMethodDefinition(parent) && parent.key === node && !parent.computed) {
+  // yes: { [NODE]: "" }
+  if (t.isProperty(parent)) {
+    return parent.key === node && parent.computed;
+  }
+
+  // no: var NODE = init;
+  // yes: var id = NODE;
+  if (t.isVariableDeclarator(parent)) {
+    return parent.id !== node;
+  }
+
+  // no: function NODE() {}
+  // no: function foo(NODE) {}
+  if (t.isFunction(parent)) {
+    for (var i = 0; i < parent.params.length; i++) {
+      var param = parent.params[i];
+      if (param === node) return false;
+    }
+
+    return parent.id !== node;
+  }
+
+  // no: class NODE {}
+  if (t.isClass(parent)) {
+    return parent.id !== node;
+  }
+
+  // yes: class { [NODE](){} }
+  if (t.isMethodDefinition(parent)) {
+    return parent.key === node && parent.computed;
+  }
+
+  // no: NODE: for (;;) {}
+  if (t.isLabeledStatement(parent)) {
     return false;
   }
 
-  // we're a catch clause param
-  if (t.isCatchClause(parent) && parent.param === node) return false;
+  // no: try {} catch (NODE) {}
+  if (t.isCatchClause(parent)) {
+    return parent.param !== node;
+  }
 
-  // we're a variable declarator id so we aren't referenced
-  if (t.isVariableDeclarator(parent) && parent.id === node) return false;
+  // no: function foo(...NODE) {}
+  if (t.isRestElement(parent)) {
+    return false;
+  }
 
-  var isMemberExpression = t.isMemberExpression(parent);
+  // no: [NODE = foo] = [];
+  // yes: [foo = NODE] = [];
+  if (t.isAssignmentPattern(parent)) {
+    return parent.right !== node;
+  }
 
-  // we're in a member expression and we're the computed property so we're referenced
-  var isComputedProperty = isMemberExpression && parent.property === node && parent.computed;
+  // no: [NODE] = [];
+  // no: ({ NODE }) = [];
+  if (t.isPattern(parent)) {
+    return false;
+  }
 
-  // we're in a member expression and we're the object so we're referenced
-  var isObject = isMemberExpression && parent.object === node;
+  // no: import NODE from "bar";
+  if (t.isImportSpecifier(parent)) {
+    return false;
+  }
 
-  // we are referenced
-  if (!isMemberExpression || isComputedProperty || isObject) return true;
+  // no: import * as NODE from "foo";
+  if (t.isImportBatchSpecifier(parent)) {
+    return false;
+  }
 
-  return false;
+  // no: class Foo { private NODE; }
+  if (t.isPrivateDeclaration(parent)) {
+    return false;
+  }
+
+  return true;
 };
 
 /**
@@ -316,13 +366,10 @@ t.toIdentifier = function (name) {
   name = name.replace(/^[-0-9]+/, "");
 
   // camel case
-  name = name.replace(/[-_\s]+(.)?/g, function (match, c) {
+  name = name.replace(/[-\s]+(.)?/g, function (match, c) {
     return c ? c.toUpperCase() : "";
   });
 
-  // remove underscores from start of name
-  name = name.replace(/^\_/, "");
-
   if (!t.isValidIdentifier(name)) {
     name = "_" + name;
   }
@@ -443,7 +490,11 @@ t.toBlock = function (node, parent) {
 };
 
 /**
- * Description
+ * Return a list of identifiers that will be assigned
+ * as a result of runtime evaluation.
+ *
+ * If an identifier is passed as `node` instead of a
+ * declaration then it's assumed to be an assignable.
  *
  * @param {Object} node
  * @param {Boolean} [map]
@@ -452,15 +503,15 @@ t.toBlock = function (node, parent) {
  */
 
 t.getIds = function (node, map, ignoreTypes) {
-  ignoreTypes = ignoreTypes || [];
-
   var search = [].concat(node);
-  var ids    = {};
+  var ids    = object();
 
   while (search.length) {
     var id = search.shift();
     if (!id) continue;
-    if (_.contains(ignoreTypes, id.type)) continue;
+
+    // blacklist types
+    if (ignoreTypes && ignoreTypes.indexOf(id.type) >= 0) continue;
 
     var nodeKeys = t.getIds.nodes[id.type];
     var arrKeys  = t.getIds.arrays[id.type];
@@ -469,6 +520,10 @@ t.getIds = function (node, map, ignoreTypes) {
 
     if (t.isIdentifier(id)) {
       ids[id.name] = id;
+    } else if (t.isExportDeclaration(id)) {
+      if (t.isDeclaration(node.declaration)) {
+        search.push(node.declaration);
+      }
     } else if (nodeKeys) {
       for (i = 0; i < nodeKeys.length; i++) {
         key = nodeKeys[i];
@@ -508,7 +563,6 @@ t.getIds.nodes = {
 t.getIds.arrays = {
   PrivateDeclaration: ["declarations"],
   ComprehensionExpression: ["blocks"],
-  ExportDeclaration: ["specifiers", "declaration"],
   ImportDeclaration: ["specifiers"],
   VariableDeclaration: ["declarations"],
   ArrayPattern: ["elements"],

package.json

@@ -1,7 +1,7 @@
 {
   "name": "6to5",
   "description": "Turn ES6 code into readable vanilla ES5 with source maps",
-  "version": "3.0.4",
+  "version": "3.0.11",
   "author": "Sebastian McKenzie <sebmck@gmail.com>",
   "homepage": "https://6to5.org/",
   "repository": "6to5/6to5",
@@ -37,28 +37,28 @@
     "chalk": "^0.5.1",
     "chokidar": "0.12.6",
     "commander": "2.6.0",
-    "core-js": "0.4.6",
-    "detect-indent": "^3.0.0",
+    "core-js": "^0.4.9",
+    "detect-indent": "3.0.0",
     "estraverse": "1.9.1",
     "esutils": "1.1.6",
     "esvalid": "1.1.0",
     "fs-readdir-recursive": "0.1.0",
-    "js-tokenizer": "^1.3.3",
+    "js-tokenizer": "1.3.3",
     "lodash": "3.0.0",
-    "output-file-sync": "^1.1.0",
+    "output-file-sync": "1.1.0",
     "private": "0.1.6",
     "regenerator-6to5": "0.8.9-6",
     "regexpu": "1.1.0",
     "roadrunner": "1.0.4",
     "source-map": "0.1.43",
     "source-map-support": "0.2.9",
-    "supports-color": "^1.2.0"
+    "supports-color": "1.2.0"
   },
   "devDependencies": {
     "browserify": "8.1.1",
     "chai": "1.10.0",
     "istanbul": "0.3.5",
-    "jscs": "^1.10.0",
+    "jscs": "1.10.0",
     "jshint": "2.6.0",
     "jshint-stylish": "1.0.0",
     "matcha": "0.6.0",

packages/6to5-runtime/package.json

@@ -1,6 +1,7 @@
 {
   "name": "6to5-runtime",
   "description": "6to5 selfContained runtime",
-  "version": "3.0.3",
+  "version": "3.0.10",
+  "repository": "6to5/6to5",
   "author": "Sebastian McKenzie <sebmck@gmail.com>"
 }

test/_transformation-helper.js

@@ -1,6 +1,7 @@
 var genHelpers = require("./_generator-helpers");
 var transform  = require("../lib/6to5/transformation/transform");
 var sourceMap  = require("source-map");
+var codeFrame  = require("../lib/6to5/helpers/code-frame");
 var esvalid    = require("esvalid");
 var Module     = require("module");
 var helper     = require("./_helper");
@@ -85,7 +86,7 @@ var run = function (task, done) {
       fn.call(global, fakeRequire, chai.assert, done);
     } catch (err) {
       err.message = exec.loc + ": " + err.message;
-      err.message += util.codeFrame(execCode);
+      err.message += codeFrame(execCode);
       throw err;
     }
   }

test/fixtures/transformation/es6-for-of-loose/let/expected.js

@@ -1,13 +1,14 @@
 "use strict";
 
 for (var _iterator = arr, _isArray = Array.isArray(_iterator), _i = 0, _iterator = _isArray ? _iterator : _iterator[Symbol.iterator]();;) {
-  var i = undefined;
+  var _ref;
   if (_isArray) {
     if (_i >= _iterator.length) break;
-    i = _iterator[_i++];
+    _ref = _iterator[_i++];
   } else {
     _i = _iterator.next();
     if (_i.done) break;
-    i = _i.value;
+    _ref = _i.value;
   }
-}
+  var i = _ref;
+}

test/fixtures/transformation/es6-for-of-loose/multiple/expected.js

@@ -1,25 +1,27 @@
 "use strict";
 
 for (var _iterator = arr, _isArray = Array.isArray(_iterator), _i = 0, _iterator = _isArray ? _iterator : _iterator[Symbol.iterator]();;) {
-  var i;
+  var _ref;
   if (_isArray) {
     if (_i >= _iterator.length) break;
-    i = _iterator[_i++];
+    _ref = _iterator[_i++];
   } else {
     _i = _iterator.next();
     if (_i.done) break;
-    i = _i.value;
+    _ref = _i.value;
   }
+  var i = _ref;
 }
 
 for (var _iterator2 = numbers, _isArray2 = Array.isArray(_iterator2), _i2 = 0, _iterator2 = _isArray2 ? _iterator2 : _iterator2[Symbol.iterator]();;) {
-  var i;
+  var _ref2;
   if (_isArray2) {
     if (_i2 >= _iterator2.length) break;
-    i = _iterator2[_i2++];
+    _ref2 = _iterator2[_i2++];
   } else {
     _i2 = _iterator2.next();
     if (_i2.done) break;
-    i = _i2.value;
+    _ref2 = _i2.value;
   }
-}
+  var i = _ref2;
+}

test/fixtures/transformation/es6-for-of-loose/var/expected.js

@@ -1,13 +1,14 @@
 "use strict";
 
 for (var _iterator = arr, _isArray = Array.isArray(_iterator), _i = 0, _iterator = _isArray ? _iterator : _iterator[Symbol.iterator]();;) {
-  var i;
+  var _ref;
   if (_isArray) {
     if (_i >= _iterator.length) break;
-    i = _iterator[_i++];
+    _ref = _iterator[_i++];
   } else {
     _i = _iterator.next();
     if (_i.done) break;
-    i = _i.value;
+    _ref = _i.value;
   }
-}
+  var i = _ref;
+}

test/fixtures/transformation/regenerator/default-parameters/exec.js

@@ -0,0 +1,6 @@
+function* foo(bar = "bar") {
+  return bar;
+}
+
+assert.deepEqual(foo().next().value, "bar");
+assert.deepEqual(foo("foo").next().value, "foo");

test/fixtures/transformation/regenerator/destructuring/exec.js

@@ -0,0 +1,5 @@
+function* foo({ bar }) {
+  return bar;
+}
+
+assert(foo({ bar: "bar" }).next().value, "bar");

test/fixtures/transformation/regenerator/rest-parameters/exec.js

@@ -0,0 +1,5 @@
+function* foo(...items) {
+  return items;
+}
+
+assert.deepEqual(foo(1, 2, 3).next().value, [1, 2, 3]);