v5.2.12

CHANGELOG.md

@@ -13,6 +13,18 @@ _Note: Gaps between patch versions are faulty/broken releases._
 
 See [CHANGELOG - 6to5](CHANGELOG-6to5.md) for the pre-4.0.0 version changelog.
 
+## 5.2.11
+
+ * **Internal**
+  * Rename `getModuleName` option to `getModuleId`, doh.
+
+## 5.2.10
+
+ * **Bug Fix**
+  * Fix numerous issues in `replaceWithSourceString`. Thanks [@pangratz](https://github.com/pangratz)!
+ * **New Feature**
+  * Add `getModuleName` option. Thanks [@jayphelps](https://github.com/jayphelps)!
+
 ## 5.2.9
 
  * **Bug Fix**

package.json

@@ -1,7 +1,7 @@
 {
   "name": "babel-core",
   "description": "Turn ES6 code into readable vanilla ES5 with source maps",
-  "version": "5.2.10",
+  "version": "5.2.12",
   "author": "Sebastian McKenzie <sebmck@gmail.com>",
   "homepage": "https://babeljs.io/",
   "repository": "babel/babel",

packages/babel-cli/package.json

@@ -1,13 +1,13 @@
 {
   "name": "babel",
   "description": "Turn ES6 code into readable vanilla ES5 with source maps",
-  "version": "5.2.9",
+  "version": "5.2.11",
   "author": "Sebastian McKenzie <sebmck@gmail.com>",
   "homepage": "https://babeljs.io/",
   "repository": "babel/babel",
   "preferGlobal": true,
   "dependencies": {
-    "babel-core": "^5.2.9",
+    "babel-core": "^5.2.11",
     "chokidar": "^1.0.0",
     "commander": "^2.6.0",
     "convert-source-map": "^1.1.0",

packages/babel-runtime/package.json

@@ -1,7 +1,7 @@
 {
   "name": "babel-runtime",
   "description": "babel selfContained runtime",
-  "version": "5.2.9",
+  "version": "5.2.11",
   "repository": "babel/babel",
   "author": "Sebastian McKenzie <sebmck@gmail.com>",
   "dependencies": {

src/babel/transformation/file/options.json

@@ -25,7 +25,7 @@
     "type": "string"
   },
 
-  "getModuleName": {
+  "getModuleId": {
     "hidden": true
   },
 

src/babel/transformation/modules/_default.js

@@ -185,8 +185,8 @@ export default class DefaultFormatter {
 
   getModuleName() {
     var opts = this.file.opts;
-    // moduleId is n/a if a `getModuleName()` is provided
-    if (opts.moduleId && !opts.getModuleName) {
+    // moduleId is n/a if a `getModuleId()` is provided
+    if (opts.moduleId && !opts.getModuleId) {
       return opts.moduleId;
     }
 
@@ -217,10 +217,9 @@ export default class DefaultFormatter {
     // normalize path separators
     moduleName = moduleName.replace(/\\/g, "/");
 
-    if (opts.getModuleName) {
-      // If return is falsy, assume they want us to use
-      // our generated default name
-      return opts.getModuleName(moduleName) || moduleName;
+    if (opts.getModuleId) {
+      // If return is falsy, assume they want us to use our generated default name
+      return opts.getModuleId(moduleName) || moduleName;
     } else {
       return moduleName;
     }

src/babel/traversal/path/index.js

@@ -510,7 +510,7 @@ export default class TraversalPath {
     }
 
     if (this.node === replacement) {
-      throw new Error("You're trying to replace a node with itself which doesn't make any sense. If you're trying to do a transformer recache then use `this.checkSelf()`");
+      return this.checkSelf();
     }
 
     // normalise inserting an entire AST

src/babel/traversal/scope.js

@@ -244,12 +244,14 @@ export default class Scope {
 
     var add = function (node) {
       if (t.isModuleDeclaration(node)) {
-        if (node.specifiers && node.specifiers.length) {
+        if (node.source) {
+          add(node.source);
+        } else if (node.specifiers && node.specifiers.length) {
           for (var i = 0; i < node.specifiers.length; i++) {
             add(node.specifiers[i]);
           }
-        } else {
-          add(node.source);
+        } else if (node.declaration) {
+          add(node.declaration);
         }
       } else if (t.isModuleSpecifier(node)) {
         add(node.local);

test/core/api.js

@@ -18,8 +18,8 @@ suite("api", function () {
     assert.ok(!result.ast);
   });
 
-  suite("getModuleName() {} option", function () {
-    // As of this commit, `getModuleName` is the only option that isn't JSON
+  suite("getModuleId() {} option", function () {
+    // As of this commit, `getModuleId` is the only option that isn't JSON
     // compatible which is why it's not inside /test/core/fixtures/transformation
 
     function getModuleNameTest(moduleFormat, expected) {
@@ -27,7 +27,7 @@ suite("api", function () {
         filename: "foo/bar/index",
         modules: moduleFormat,
         moduleIds: true,
-        getModuleName: function (name) {
+        getModuleId: function (name) {
           return name.replace(/\/index$/, "");
         }
       });

test/core/fixtures/transformation/es6.modules-common/hoist-function-exports/expected.js

@@ -5,15 +5,15 @@ Object.defineProperty(exports, "__esModule", {
 });
 exports.nextOdd = nextOdd;
 
-var _isEven = require("./evens");
+var _evens = require("./evens");
 
 function nextOdd(n) {
-  return _isEven.isEven(n) ? n + 1 : n + 2;
+  return _evens.isEven(n) ? n + 1 : n + 2;
 }
 
 var isOdd = (function (isEven) {
   return function (n) {
     return !isEven(n);
   };
-})(_isEven.isEven);
-exports.isOdd = isOdd;
+})(_evens.isEven);
+exports.isOdd = isOdd;

test/core/fixtures/transformation/es6.modules-common/imports-default/expected.js

@@ -4,7 +4,7 @@ var _foo = require("foo");
 
 var _foo2 = babelHelpers.interopRequireDefault(_foo);
 
-var _foo22 = babelHelpers.interopRequireDefault(_foo);
+var _foo3 = babelHelpers.interopRequireDefault(_foo);
 
 _foo2["default"];
-_foo22["default"];
+_foo3["default"];

test/core/fixtures/transformation/es6.modules-common/imports-glob/expected.js

@@ -1,5 +1,5 @@
 "use strict";
 
-var _import = require("foo");
+var _foo = require("foo");
 
-var foo = babelHelpers.interopRequireWildcard(_import);
+var foo = babelHelpers.interopRequireWildcard(_foo);

test/core/fixtures/transformation/es6.modules-common/imports-mixing/expected.js

@@ -1,8 +1,8 @@
 "use strict";
 
-var _foo$xyz = require("foo");
+var _foo = require("foo");
 
-var _foo$xyz2 = babelHelpers.interopRequireDefault(_foo$xyz);
+var _foo2 = babelHelpers.interopRequireDefault(_foo);
 
-_foo$xyz2["default"];
-_foo$xyz.baz;
+_foo2["default"];
+_foo.baz;

test/core/fixtures/transformation/es6.modules-common/imports-named/expected.js

@@ -1,10 +1,10 @@
 "use strict";
 
-var _bar = require("foo");
+var _foo = require("foo");
 
-_bar.bar;
-_bar.bar2;
-_bar.baz;
-_bar.bar;
-_bar.bar;
-_bar.xyz;
+_foo.bar;
+_foo.bar2;
+_foo.baz;
+_foo.bar;
+_foo.bar;
+_foo.xyz;

test/core/fixtures/transformation/es6.modules-common/overview/expected.js

@@ -10,22 +10,22 @@ require("foo-bar");
 
 require("./directory/foo-bar");
 
-var _foo = require("foo2");
+var _foo2 = require("foo2");
 
-var _foo2 = babelHelpers.interopRequireDefault(_foo);
+var _foo22 = babelHelpers.interopRequireDefault(_foo2);
 
-var _import = require("foo3");
+var _foo3 = require("foo3");
 
-var foo2 = babelHelpers.interopRequireWildcard(_import);
+var foo2 = babelHelpers.interopRequireWildcard(_foo3);
 
-var _bar = require("foo4");
+var _foo4 = require("foo4");
 
-var _bar2 = require("foo5");
+var _foo5 = require("foo5");
 
 exports.test = test;
 var test = 5;
 
 exports.test = test;
-_bar.bar;
-_bar2.foo;
-_foo2["default"];
+_foo4.bar;
+_foo5.foo;
+_foo22["default"];

test/core/fixtures/transformation/es7.export-extensions/default-commonjs/expected.js

@@ -4,8 +4,8 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 
-var _foo2 = require("bar");
+var _bar = require("bar");
 
-var _foo3 = babelHelpers.interopRequireDefault(_foo2);
+var _bar2 = babelHelpers.interopRequireDefault(_bar);
 
-exports.foo = _foo3["default"];
+exports.foo = _bar2["default"];

test/core/fixtures/transformation/es7.export-extensions/namespace-commonjs/expected.js

@@ -4,8 +4,8 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 
-var _import = require("bar");
+var _bar = require("bar");
 
-var _foo = babelHelpers.interopRequireWildcard(_import);
+var _foo = babelHelpers.interopRequireWildcard(_bar);
 
-exports.foo = _foo;
+exports.foo = _foo;

test/core/fixtures/transformation/misc/regression-lodash-tostring-import/expected.js

@@ -1,7 +1,7 @@
 "use strict";
 
-var _toString = require("foo");
+var _foo = require("foo");
 
-var _toString2 = babelHelpers.interopRequireDefault(_toString);
+var _foo2 = babelHelpers.interopRequireDefault(_foo);
 
-_toString2["default"];
+_foo2["default"];

test/core/fixtures/transformation/runtime/full/expected.js

@@ -17,11 +17,11 @@ _Object$defineProperty(exports, "__esModule", {
 exports.giveWord = giveWord;
 var marked0$0 = [giveWord].map(_regeneratorRuntime.mark);
 
-var _foo = require("someModule");
+var _someModule = require("someModule");
 
-var _foo2 = _interopRequireDefault(_foo);
+var _someModule2 = _interopRequireDefault(_someModule);
 
-var bar = _interopRequireWildcard(_foo);
+var bar = _interopRequireWildcard(_someModule);
 
 var myWord = _Symbol("abc");
 exports.myWord = myWord;
@@ -40,5 +40,5 @@ function giveWord() {
   }, marked0$0[0], this);
 }
 
-_foo2["default"];
-bar;
+_someModule2["default"];
+bar;

test/core/fixtures/transformation/spec.function-name/modules-2/expected.js

@@ -4,9 +4,9 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 
-var _last2 = require("lodash/array/last");
+var _lodashArrayLast = require("lodash/array/last");
 
-var _last3 = babelHelpers.interopRequireDefault(_last2);
+var _lodashArrayLast2 = babelHelpers.interopRequireDefault(_lodashArrayLast);
 
 var Container = (function () {
   function Container() {
@@ -20,11 +20,11 @@ var Container = (function () {
         return;
       }
 
-      return _last3["default"](this.tokens.get(key));
+      return _lodashArrayLast2["default"](this.tokens.get(key));
     }
   }]);
   return Container;
 })();
 
 exports["default"] = Container;
-module.exports = exports["default"];
+module.exports = exports["default"];

test/core/fixtures/transformation/spec.function-name/modules-3/expected.js

@@ -4,7 +4,7 @@ Object.defineProperty(exports, "__esModule", {
   value: true
 });
 
-var _getForm2 = require("./store");
+var _store = require("./store");
 
 var Login = (function (_React$Component) {
   function Login() {
@@ -19,11 +19,11 @@ var Login = (function (_React$Component) {
   babelHelpers.createClass(Login, [{
     key: "getForm",
     value: function getForm() {
-      return _getForm2.getForm().toJS();
+      return _store.getForm().toJS();
     }
   }]);
   return Login;
 })(React.Component);
 
 exports["default"] = Login;
-module.exports = exports["default"];
+module.exports = exports["default"];