v5.6.6

Update Regenerator dependency to 0.8.31.

CHANGELOG.md

@@ -13,6 +13,64 @@ _Note: Gaps between patch versions are faulty/broken releases._
 
 See [CHANGELOG - 6to5](CHANGELOG-6to5.md) for the pre-4.0.0 version changelog.
 
+## 5.6.6
+
+ * **Bug Fix**
+  * Fix weird parser bug where `void` type annotations were being parsed as keywords causing the tokeniser to lose track of context.
+
+## 5.6.5
+
+ * *Bug Fix**
+  * Fix nested functions causing rest parameter optimisation to not properly detect when it should deopt on a reference.
+ * **Internal**
+  * Update Regenerator `0.8.31`.
+
+## 5.6.4
+
+ * **Internal**
+  * Add `ParenthesizedExpression` node type.
+
+## 5.6.3
+
+ * **Bug Fix**
+  * Fix rest parameter array allocation loop being incorrectly aliased.
+
+## 5.6.2
+
+ * **Bug Fix**
+  * Fix method key literals not turning into computed member expression in loose mode.
+  * Elect rest parameters in spread element position as candidates instead of replacing them in place.
+
+## 5.6.0
+
+ * **Bug Fix**
+  * Fix istanbul interop for register hook when registering for non-existence extension.
+  * Fix super class constructor call differing for no constructor in derived classes.
+  * Disable module import receiver when in loose mode.
+  * Fix duplicate filenames when using `babel` CLI when passing multiple matching patterns.
+  * Register labels as bindings to fix undeclared variable checks.
+ * **Polish**
+  * Remove unnecessary string binary expressions when transforming template literals.
+  * Support module live bindings in arbitary positions not in Program statement position.
+  * Throw error when attemping to replace a `Program` root node with another node not of type `Program`.
+  * Optimise rest parameters in spread element position and allocate rest array at the earliest common ancestor of all references.
+  * Generate original number representation when value was not changed.
+  * Check for invalid binding identifiers when generating inferred method names.
+  * Don't terminate CLI when watching files fail compilation on init.
+ * **New Feature**
+  * Add new plugin API.
+ * **Internal**
+  * Split react displayName addition into a plugin.
+  * Add check for `JSXMemberExpression` to `t.isReferenced`.
+  * Move `validation.undeclaredVariableCheck` transformer up.
+  * Start great core-to-plugin exodus.
+  * Add `BindingIdentifier` virtual type.
+  * Hidden class optimisations.
+  * Array allocation optimisations.
+  * Update `regenerator`.
+  * Update `js-tokens`.
+  * Sync with upstream Acorn.
+
 ## 5.5.8
 
  * **Internal**

package.json

@@ -1,7 +1,7 @@
 {
   "name": "babel-core",
   "description": "A compiler for writing next generation JavaScript",
-  "version": "5.6.0",
+  "version": "5.6.6",
   "author": "Sebastian McKenzie <sebmck@gmail.com>",
   "homepage": "https://babeljs.io/",
   "license": "MIT",
@@ -31,7 +31,7 @@
     "acorn-jsx": "^1.0.0",
     "ast-types": "~0.7.0",
     "babel-plugin-constant-folding": "^1.0.1",
-    "babel-plugin-dead-code-elimination": "^1.0.1",
+    "babel-plugin-dead-code-elimination": "^1.0.2",
     "babel-plugin-eval": "^1.0.1",
     "babel-plugin-inline-environment-variables": "^1.0.1",
     "babel-plugin-jscript": "^1.0.1",
@@ -64,7 +64,7 @@
     "output-file-sync": "^1.1.0",
     "path-is-absolute": "^1.0.0",
     "private": "^0.1.6",
-    "regenerator": "0.8.30",
+    "regenerator": "0.8.31",
     "regexpu": "^1.1.2",
     "repeating": "^1.1.2",
     "resolve": "^1.1.6",
@@ -77,7 +77,7 @@
     "trim-right": "^1.0.0"
   },
   "devDependencies": {
-    "babel": "5.5.8",
+    "babel": "5.5.7",
     "browserify": "^9.0.8",
     "chai": "^2.2.0",
     "eslint": "^0.21.2",

packages/babel-cli/package.json

@@ -1,14 +1,14 @@
 {
   "name": "babel",
   "description": "Turn ES6 code into readable vanilla ES5 with source maps",
-  "version": "5.5.8",
+  "version": "5.6.5",
   "author": "Sebastian McKenzie <sebmck@gmail.com>",
   "homepage": "https://babeljs.io/",
   "license": "MIT",
   "repository": "babel/babel",
   "preferGlobal": true,
   "dependencies": {
-    "babel-core": "^5.5.8",
+    "babel-core": "^5.6.5",
     "chokidar": "^1.0.0",
     "commander": "^2.6.0",
     "convert-source-map": "^1.1.0",
@@ -26,4 +26,4 @@
     "babel-external-helpers": "./bin/babel-external-helpers",
     "babel-plugin": "./bin/babel-plugin/index.js"
   }
-}
+}

packages/babel-runtime/package.json

@@ -1,7 +1,7 @@
 {
   "name": "babel-runtime",
   "description": "babel selfContained runtime",
-  "version": "5.5.8",
+  "version": "5.6.5",
   "license": "MIT",
   "repository": "babel/babel",
   "author": "Sebastian McKenzie <sebmck@gmail.com>",

packages/build-runtime.js

@@ -75,7 +75,7 @@ writeFile("regenerator/runtime.js", selfContainify(readFile("regenerator/runtime
 
 //
 
-var coreDefinitions = require("../lib/babel/transformation/transformers/other/runtime/definitions");
+var coreDefinitions = require("babel-plugin-runtime/lib/definitions");
 
 var paths = ["is-iterable", "get-iterator"];
 

src/acorn/plugins/flow.js

@@ -1,3 +1,4 @@
+Error.stackTraceLimit = Infinity;
 var acorn = require("../src/index")
 
 var pp = acorn.Parser.prototype
@@ -41,8 +42,11 @@ pp.flow_parseDeclareFunction = function (node) {
   typeNode.rest = tmp.rest
   this.expect(tt.parenR)
 
+  var oldInType = this.inType
+  this.inType = true
   this.expect(tt.colon)
   typeNode.returnType = this.flow_parseType()
+  this.inType = oldInType
 
   typeContainer.typeAnnotation = this.finishNode(typeNode, "FunctionTypeAnnotation")
   id.typeAnnotation = this.finishNode(typeContainer, "TypeAnnotation")
@@ -352,12 +356,6 @@ pp.flow_parseGenericType = function (start, id) {
   return this.finishNode(node, "GenericTypeAnnotation")
 }
 
-pp.flow_parseVoidType = function () {
-  var node = this.startNode()
-  this.expect(tt._void)
-  return this.finishNode(node, "VoidTypeAnnotation")
-}
-
 pp.flow_parseTypeofType = function () {
   var node = this.startNode()
   this.expect(tt._typeof)
@@ -411,6 +409,9 @@ pp.flow_identToTypeAnnotation = function (start, node, id) {
     case "any":
       return this.finishNode(node, "AnyTypeAnnotation")
 
+    case "void":
+      return this.finishNode(node, "VoidTypeAnnotation")
+
     case "bool":
     case "boolean":
       return this.finishNode(node, "BooleanTypeAnnotation")
@@ -524,14 +525,8 @@ pp.flow_parsePrimaryType = function () {
       return this.finishNode(node, "StringLiteralTypeAnnotation")
 
     default:
-      if (this.type.keyword) {
-        switch (this.type.keyword) {
-          case "void":
-            return this.flow_parseVoidType()
-
-          case "typeof":
-            return this.flow_parseTypeofType()
-        }
+      if (this.type.keyword === "typeof") {
+        return this.flow_parseTypeofType()
       }
   }
 
@@ -694,6 +689,18 @@ acorn.plugins.flow = function (instance) {
     }
   })
 
+  // don't consider `void` to be a keyword as then it'll use the void token type
+  // and set startExpr
+  instance.extend("isKeyword", function (inner) {
+    return function(name) {
+      if (this.inType && name === "void") {
+        return false
+      } else {
+        return inner.call(this, name)
+      }
+    }
+  })
+
   instance.extend("readToken", function (inner) {
     return function(code) {
       if (this.inType && (code === 62 || code === 60)) {

src/acorn/src/lookahead.js

@@ -19,7 +19,11 @@ var STATE_KEYS = [
   "exprAllowed",
   "potentialArrowAt",
   "currLine",
-  "input"
+  "input",
+  "inType",
+  "inFunction",
+  "inGenerator",
+  "labels"
 ];
 
 pp.getState = function () {
@@ -29,6 +33,7 @@ pp.getState = function () {
     state[key] = this[key]
   }
   state.context = this.context.slice()
+  state.labels = this.labels.slice()
   return state
 };
 

src/acorn/src/state.js

@@ -4,11 +4,11 @@ import {lineBreak} from "./whitespace"
 
 export function Parser(options, input, startPos) {
   this.options = options
-  this.loadPlugins(this.options.plugins)
   this.sourceFile = this.options.sourceFile || null
   this.isKeyword = keywords[this.options.ecmaVersion >= 6 ? 6 : 5]
   this.isReservedWord = reservedWords[this.options.ecmaVersion]
   this.input = input
+  this.loadPlugins(this.options.plugins)
 
   // Set up token state
 

src/acorn/src/tokentype.js

@@ -112,7 +112,7 @@ kw("case", beforeExpr)
 kw("catch")
 kw("continue")
 kw("debugger")
-kw("default")
+kw("default", beforeExpr)
 kw("do", {isLoop: true})
 kw("else", beforeExpr)
 kw("finally")

src/babel/generation/buffer.js

@@ -54,9 +54,10 @@ export default class Buffer {
     this.space();
   }
 
-  space() {
-    if (this.format.compact) return;
-    if (this.buf && !this.isLast(" ") && !this.isLast("\n")) {
+  space(force?) {
+    if (!force && this.format.compact) return;
+
+    if (force || this.buf && !this.isLast(" ") && !this.isLast("\n")) {
       this.push(" ");
     }
   }
@@ -155,8 +156,12 @@ export default class Buffer {
     this.buf += str;
   }
 
-  endsWith(str) {
-    return this.buf.slice(-str.length) === str;
+  endsWith(str, buf = this.buf) {
+    if (str.length === 1) {
+      return buf[buf.length - 1] === str;
+    } else {
+      return buf.slice(-str.length) === str;
+    }
   }
 
   isLast(cha) {

src/babel/generation/generators/expressions.js

@@ -2,19 +2,19 @@ import isNumber from "lodash/lang/isNumber";
 import * as t from "../../types";
 
 export function UnaryExpression(node, print) {
-  var hasSpace = /[a-z]$/.test(node.operator);
+  var needsSpace = /[a-z]$/.test(node.operator);
   var arg = node.argument;
 
   if (t.isUpdateExpression(arg) || t.isUnaryExpression(arg)) {
-    hasSpace = true;
+    needsSpace = true;
   }
 
   if (t.isUnaryExpression(arg) && arg.operator === "!") {
-    hasSpace = false;
+    needsSpace = false;
   }
 
   this.push(node.operator);
-  if (hasSpace) this.push(" ");
+  if (needsSpace) this.push(" ");
   print.plain(node.argument);
 }
 
@@ -24,6 +24,12 @@ export function DoExpression(node, print) {
   print.plain(node.body);
 }
 
+export function ParenthesizedExpression(node, print) {
+  this.push("(");
+  print.plain(node.expression);
+  this.push(")");
+}
+
 export function UpdateExpression(node, print) {
   if (node.prefix) {
     this.push(node.operator);
@@ -77,19 +83,16 @@ export function CallExpression(node, print) {
 
   this.push("(");
 
-  var separator = ",";
-
-  var isPrettyCall = node._prettyCall && !this.format.retainLines;
+  var isPrettyCall = node._prettyCall && !this.format.retainLines && !this.format.compact;
 
+  var separator;
   if (isPrettyCall) {
-    separator += "\n";
+    separator = ",\n";
     this.newline();
     this.indent();
-  } else {
-    separator += " ";
   }
 
-  print.list(node.arguments, { separator: separator });
+  print.list(node.arguments, { separator });
 
   if (isPrettyCall) {
     this.newline();
@@ -135,9 +138,22 @@ export function AssignmentPattern(node, print) {
 export function AssignmentExpression(node, print) {
   // todo: add cases where the spaces can be dropped when in compact mode
   print.plain(node.left);
-  this.push(" ");
+
+  var spaces = node.operator === "in" || node.operator === "instanceof";
+  this.space(spaces);
+
   this.push(node.operator);
-  this.push(" ");
+
+  if (!spaces) {
+    // space is mandatory to avoid outputting <!--
+    // http://javascript.spec.whatwg.org/#comment-syntax
+    spaces = node.operator === "<" &&
+             t.isUnaryExpression(node.right, { prefix: true, operator: "!" }) &&
+             t.isUnaryExpression(node.right.argument, { prefix: true, operator: "--" });
+  }
+
+  this.space(spaces);
+
   print.plain(node.right);
 }
 

src/babel/generation/generators/methods.js

@@ -42,7 +42,7 @@ export function _method(node, print) {
   }
 
   this._params(value, print);
-  this.push(" ");
+  this.space();
   print.plain(value.body);
 }
 

src/babel/generation/generators/statements.js

@@ -33,13 +33,13 @@ export function ForStatement(node, print) {
   this.push(";");
 
   if (node.test) {
-    this.push(" ");
+    this.space();
     print.plain(node.test);
   }
   this.push(";");
 
   if (node.update) {
-    this.push(" ");
+    this.space();
     print.plain(node.update);
   }
 
@@ -190,16 +190,29 @@ export function VariableDeclaration(node, print, parent) {
     }
   }
 
-  var sep = ",";
+  //
+  // use a pretty separator when we aren't in compact mode, have initializers and don't have retainLines on
+  // this will format declarations like:
+  //
+  //   var foo = "bar", bar = "foo";
+  //
+  // into
+  //
+  //   var foo = "bar",
+  //       bar = "foo";
+  //
+
+  var sep;
   if (!this.format.compact && !this.format.concise && hasInits && !this.format.retainLines) {
-    sep += `\n${repeating(" ", node.kind.length + 1)}`;
-  } else {
-    sep += " ";
+    sep = `,\n${repeating(" ", node.kind.length + 1)}`;
   }
 
+  //
+
   print.list(node.declarations, { separator: sep });
 
   if (t.isFor(parent)) {
+    // don't give semicolons to these nodes since they'll be inserted in the parent generator
     if (parent.left === node || parent.init === node) return;
   }
 

src/babel/generation/generators/types.js

@@ -80,7 +80,7 @@ export function ArrayExpression(node, print) {
       // both (all) of the holes.
       this.push(",");
     } else {
-      if (i > 0) this.push(" ");
+      if (i > 0) this.space();
       print.plain(elem);
       if (i < len - 1) this.push(",");
     }

src/babel/generation/index.js

@@ -128,8 +128,7 @@ class CodeGenerator {
     // catch up to this nodes newline if we're behind
     if (node.loc && this.format.retainLines && this.buffer.buf) {
       var needsParens = false;
-      if (!leftParenPrinted && parent &&
-          this.position.line < node.loc.start.line && t.isTerminatorless(parent)) {
+      if (!leftParenPrinted && parent && this.position.line < node.loc.start.line && t.isTerminatorless(parent)) {
         needsParens = true;
         this._push("(");
       }

src/babel/generation/node/printer.js

@@ -18,7 +18,11 @@ export default class NodePrinter {
   }
 
   list(items, opts = {}) {
-    if (opts.separator == null) opts.separator = ", ";
+    if (opts.separator == null) {
+      opts.separator = ",";
+      if (!this.generator.format.compact) opts.separator += " ";
+    }
+
     return this.join(items, opts);
   }
 

src/babel/transformation/helpers/replace-supers.js

@@ -169,7 +169,13 @@ export default class ReplaceSupers {
 
       if (methodName.name === "constructor") {
         // constructor() { super(); }
-        return t.memberExpression(superRef, t.identifier("call"));
+        if (parent.arguments.length === 2 && t.isSpreadElement(parent.arguments[1]) && t.isIdentifier(parent.arguments[1].argument, { name: "arguments" })) {
+          // special case single arguments spread
+          parent.arguments[1] = parent.arguments[1].argument;
+          return t.memberExpression(superRef, t.identifier("apply"));
+        } else {
+          return t.memberExpression(superRef, t.identifier("call"));
+        }
       } else {
         id = superRef;
 

src/babel/transformation/transformers/es6/arrow-functions.js

@@ -1,9 +1,6 @@
-import * as t from "../../../types";
-
 export var visitor = {
   ArrowFunctionExpression(node) {
-    t.ensureBlock(node);
-
+    this.ensureBlock();
     node.expression = false;
     node.type = "FunctionExpression";
     node.shadow = true;

src/babel/transformation/transformers/es6/classes.js

@@ -477,7 +477,7 @@ class ClassTransformer {
 
         var classRef = this.classRef;
         if (!node.static) classRef = t.memberExpression(classRef, t.identifier("prototype"));
-        var methodName = t.memberExpression(classRef, node.key, node.computed);
+        var methodName = t.memberExpression(classRef, node.key, node.computed || t.isLiteral(node.key));
 
         var expr = t.expressionStatement(t.assignmentExpression("=", methodName, node.value));
         t.inheritsComments(expr, node);

src/babel/transformation/transformers/es6/destructuring.js

@@ -18,7 +18,7 @@ export var visitor = {
         t.variableDeclarator(temp)
       ]);
 
-      t.ensureBlock(node);
+      this.ensureBlock();
 
       node.body.body.unshift(t.variableDeclaration("var", [
         t.variableDeclarator(left, temp)
@@ -48,7 +48,7 @@ export var visitor = {
 
     destructuring.init(pattern, key);
 
-    t.ensureBlock(node);
+    this.ensureBlock();
 
     var block = node.body;
     block.body = nodes.concat(block.body);
@@ -84,7 +84,7 @@ export var visitor = {
       destructuring.init(pattern, ref);
     }
 
-    t.ensureBlock(node);
+    this.ensureBlock();
 
     var block = node.body;
     block.body = nodes.concat(block.body);

src/babel/transformation/transformers/es6/for-of.js

@@ -17,7 +17,7 @@ export var visitor = {
     var block  = loop.body;
 
     // ensure that it's a block so we can take all its statements
-    t.ensureBlock(node);
+    this.ensureBlock();
 
     // add the value declaration to the new loop body
     if (declar) {

src/babel/transformation/transformers/es6/parameters.default.js

@@ -27,7 +27,7 @@ export var visitor = {
     if (!hasDefaults(node)) return;
 
     // ensure it's a block, useful for arrow functions
-    t.ensureBlock(node);
+    this.ensureBlock();
 
     var state = {
       iife: false,

src/babel/transformation/transformers/es6/parameters.rest.js

@@ -12,9 +12,10 @@ var memberExpressionOptimisationVisitor = {
   Function(node, parent, scope, state) {
     // skip over functions as whatever `arguments` we reference inside will refer
     // to the wrong function
+    var oldNoOptimise = state.noOptimise;
     state.noOptimise = true;
     this.traverse(memberExpressionOptimisationVisitor, state);
-    state.noOptimise = false;
+    state.noOptimise = oldNoOptimise;
     this.skip();
   },
 
@@ -27,7 +28,9 @@ var memberExpressionOptimisationVisitor = {
     // is this a referenced identifier and is it referencing the rest parameter?
     if (node.name !== state.name) return;
 
-    if (!state.noOptimise) {
+    if (state.noOptimise) {
+      state.deopted = true;
+    } else {
       if (this.parentPath.isMemberExpression({ computed: true, object: node })) {
         // if we know that this member expression is referencing a number then we can safely
         // optimise it
@@ -42,14 +45,11 @@ var memberExpressionOptimisationVisitor = {
       if (this.parentPath.isSpreadElement() && state.offset === 0) {
         var call = this.parentPath.parentPath;
         if (call.isCallExpression() && call.node.arguments.length === 1) {
-          return state.argumentsNode;
+          state.candidates.push(this);
+          return;
         }
       }
-    }
 
-    if (state.noOptimise) {
-      state.deopted = true;
-    } else {
       state.references.push(this);
     }
   }
@@ -99,7 +99,6 @@ export var visitor = {
     }
 
     // check and optimise for extremely common cases
-
     var state = {
       references: [],
       offset:     node.params.length,
@@ -124,7 +123,9 @@ export var visitor = {
       if (state.candidates.length) {
         for (var candidate of (state.candidates: Array)) {
           candidate.replaceWith(argsId);
-          optimiseMemberExpression(candidate.parent, state.offset);
+          if (candidate.parentPath.isMemberExpression()) {
+            optimiseMemberExpression(candidate.parent, state.offset);
+          }
         }
       }
       return;
@@ -132,6 +133,9 @@ export var visitor = {
       state.references = state.references.concat(state.candidates);
     }
 
+    // deopt shadowed functions as transforms like regenerator may try touch the allocation loop
+    state.deopted = state.deopted || !!node.shadow;
+
     //
 
     var start = t.literal(node.params.length);
@@ -170,13 +174,13 @@ export var visitor = {
       LEN:        len
     });
 
-    if (!state.deopted) {
+    if (state.deopted) {
+      loop._blockHoist = node.params.length + 1;
+      node.body.body.unshift(loop);
+    } else {
       // perform allocation at the lowest common denominator of all references
+      loop._blockHoist = 1;
       this.getEarliestCommonAncestorFrom(state.references).getStatementParent().insertBefore(loop);
-      return;
     }
-
-    loop._blockHoist = node.params.length + 1;
-    node.body.body.unshift(loop);
   }
 };

src/babel/transformation/transformers/es6/spread.js

@@ -1,7 +1,7 @@
 import * as t from "../../../types";
 
 function getSpreadLiteral(spread, scope) {
-  if (scope.hub.file.isLoose("es6.spread")) {
+  if (scope.hub.file.isLoose("es6.spread") && !t.isIdentifier(spread.argument, { name: "arguments" })) {
     return spread.argument;
   } else {
     return scope.toArray(spread.argument, true);

src/babel/transformation/transformers/es6/tail-call.js

@@ -150,7 +150,7 @@ class TailCallTransformer {
 
     //
 
-    var body = t.ensureBlock(node).body;
+    var body = this.path.ensureBlock().body;
 
     for (var i = 0; i < body.length; i++) {
       var bodyNode = body[i];

src/babel/traversal/path/context.js

@@ -230,6 +230,7 @@ export function unshiftContext(context) {
  */
 
 export function setup(parentPath, container, listKey, key) {
+  this.inList    = !!listKey;
   this.listKey   = listKey;
   this.parentKey = listKey || key;
   this.container = container;

src/babel/traversal/path/conversion.js

@@ -22,3 +22,11 @@ export function toComputedKey(): Object {
 
   return key;
 }
+
+/**
+ * Description
+ */
+
+export function ensureBlock() {
+  return t.ensureBlock(this.node);
+}

src/babel/traversal/path/index.js

@@ -21,6 +21,7 @@ export default class NodePath {
     this.context            = null;
     this.container          = null;
     this.listKey            = null;
+    this.inList             = false;
     this.parentKey          = null;
     this.key                = null;
     this.node               = null;

src/babel/traversal/path/inference/index.js

@@ -61,9 +61,11 @@ export function _getTypeAnnotation(): ?Object {
  * Description
  */
 
-export function isBaseType(baseName: string): boolean {
-  var type = this.getTypeAnnotation();
+export function isBaseType(baseName: string, soft?): boolean {
+  return _isBaseType(baseName, this.getTypeAnnotation(), soft);
+}
 
+function _isBaseType(baseName: string, type?, soft?): boolean {
   if (baseName === "string") {
     return t.isStringTypeAnnotation(type);
   } else if (baseName === "number") {
@@ -75,7 +77,31 @@ export function isBaseType(baseName: string): boolean {
   } else if (baseName === "mixed") {
     return t.isMixedTypeAnnotation(type);
   } else {
-    throw new Error(`Unknown base type ${baseName}`);
+    if (soft) {
+      return false;
+    } else {
+      throw new Error(`Unknown base type ${baseName}`);
+    }
+  }
+}
+
+/**
+ * Description
+ */
+
+export function couldBeBaseType(name: string): boolean {
+  var type = this.getTypeAnnotation();
+  if (t.isAnyTypeAnnotation(type)) return true;
+
+  if (t.isUnionTypeAnnotation(type)) {
+    for (var type2 of (type.types: Array)) {
+      if (t.isAnyTypeAnnotation(type2) || _isBaseType(name, type2, true)) {
+        return true;
+      }
+    }
+    return false;
+  } else {
+    return _isBaseType(name, type, true);
   }
 }
 

src/babel/traversal/path/inference/inferers.js

@@ -140,7 +140,7 @@ export function ObjectExpression() {
 
 //
 
-export function ArrayExpression () {
+export function ArrayExpression() {
   return t.genericTypeAnnotation(t.identifier("Array"));
 }
 

src/babel/traversal/path/replacement.js

@@ -92,14 +92,14 @@ export function replaceWith(replacement, whateverAllowed) {
     return;
   }
 
+  if (this.isProgram() && !t.isProgram(replacement)) {
+    throw new Error("You can only replace a Program root node with another Program node");
+  }
+
   // normalise inserting an entire AST
   if (t.isProgram(replacement) && !this.isProgram()) {
     replacement = replacement.body;
     whateverAllowed = true;
-  } else {
-    if (this.isProgram()) {
-      throw new Error("You can only replace a Program root node with another Program node");
-    }
   }
 
   if (Array.isArray(replacement)) {

src/babel/types/alias-keys.json

@@ -71,6 +71,7 @@
   "MetaProperty":              ["Expression"],
   "NewExpression":             ["Expression"],
   "ObjectExpression":          ["Expression"],
+  "ParenthesizedExpression":   ["Expression"],
   "SequenceExpression":        ["Expression"],
   "TaggedTemplateExpression":  ["Expression"],
   "ThisExpression":            ["Expression"],

src/babel/types/validators.js

@@ -23,7 +23,7 @@ export function isReferenced(node: Object, parent: Object): boolean {
   switch (parent.type) {
     // yes: PARENT[NODE]
     // yes: NODE.child
-    // no: parent.CHILD
+    // no: parent.NODE
     case "MemberExpression":
     case "JSXMemberExpression":
       if (parent.property === node && parent.computed) {
@@ -73,21 +73,17 @@ export function isReferenced(node: Object, parent: Object): boolean {
         return parent.local === node;
       }
 
-    // no: import NODE from "foo";
-    case "ImportDefaultSpecifier":
-      return false;
-
-    // no: import * as NODE from "foo";
-    case "ImportNamespaceSpecifier":
-      return false;
-
     // no: <div NODE="foo" />
     case "JSXAttribute":
       return parent.name !== node;
 
+    // no: import NODE from "foo";
+    // no: import * as NODE from "foo";
     // no: import { NODE as foo } from "foo";
     // no: import { foo as NODE } from "foo";
     // no: import NODE from "bar";
+    case "ImportDefaultSpecifier":
+    case "ImportNamespaceSpecifier":
     case "ImportSpecifier":
       return false;
 
@@ -112,12 +108,16 @@ export function isReferenced(node: Object, parent: Object): boolean {
     case "RestElement":
       return false;
 
-    // no: [NODE = foo] = [];
-    // yes: [foo = NODE] = [];
+    // yes: left = NODE;
+    // no: NODE = right;
     case "AssignmentExpression":
-    case "AssignmentPattern":
       return parent.right === node;
 
+    // no: [NODE = foo] = [];
+    // no: [foo = NODE] = [];
+    case "AssignmentPattern":
+      return false;
+
     // no: [NODE] = [];
     // no: ({ NODE }) = [];
     case "ObjectPattern":
@@ -195,7 +195,7 @@ export function isImmutable(node: Object): boolean {
 
   if (t.isLiteral(node)) {
     if (node.regex) {
-      // regexes are mutable
+      // regexs are mutable
       return false;
     } else {
       // immutable!

src/babel/types/visitor-keys.json

@@ -46,6 +46,7 @@
   "Noop":                      [],
   "ObjectExpression":          ["properties"],
   "ObjectPattern":             ["properties", "typeAnnotation"],
+  "ParenthesizedExpression":   ["expression"],
   "Program":                   ["body"],
   "Property":                  ["key", "value", "decorators"],
   "RestElement":               ["argument", "typeAnnotation"],

test/acorn/tests-flow.js

@@ -11148,3 +11148,9 @@ for (var ns in fbTestFixture) {
     });
   }
 }
+
+test("<Foo foo={function (): void {}} />", {}, {
+  ecmaVersion: 6,
+  sourceType: "module",
+  plugins: { jsx: true, flow: true },
+});

test/acorn/tests-harmony.js

@@ -15328,3 +15328,5 @@ test("({ ['__proto__']: 1, __proto__: 2 })", {}, {ecmaVersion: 6});
 test("({ __proto__() { return 1 }, __proto__: 2 })", {}, {ecmaVersion: 6});
 test("({ get __proto__() { return 1 }, __proto__: 2 })", {}, {ecmaVersion: 6});
 test("({ __proto__, __proto__: 2 })", {}, {ecmaVersion: 6});
+
+test("export default /foo/", {}, {ecmaVersion: 6, sourceType: "module"});

test/core/fixtures/transformation/es6.classes-loose/accessing-super-class/expected.js

@@ -10,7 +10,7 @@ var Test = (function (_Foo) {
     _Foo.call(this);
     _Foo.prototype.test.call(this);
 
-    _Foo.call.apply(_Foo, [this].concat(babelHelpers.slice.call(arguments)));
+    _Foo.apply(this, arguments);
     _Foo.call.apply(_Foo, [this, "test"].concat(babelHelpers.slice.call(arguments)));
 
     (_Foo$prototype$test = _Foo.prototype.test).call.apply(_Foo$prototype$test, [this].concat(babelHelpers.slice.call(arguments)));
@@ -36,4 +36,4 @@ var Test = (function (_Foo) {
   };
 
   return Test;
-})(Foo);
+})(Foo);

test/core/fixtures/transformation/es6.classes-loose/literal-key/actual.js

@@ -0,0 +1,5 @@
+class Foo {
+  "bar"() {
+
+  }
+}

test/core/fixtures/transformation/es6.classes-loose/literal-key/expected.js

@@ -0,0 +1,11 @@
+"use strict";
+
+var Foo = (function () {
+  function Foo() {
+    babelHelpers.classCallCheck(this, Foo);
+  }
+
+  Foo.prototype["bar"] = function bar() {};
+
+  return Foo;
+})();

test/core/fixtures/transformation/es6.classes-loose/super-class-id-member-expression/expected.js

@@ -4,7 +4,7 @@ var BaseController = (function (_Chaplin$Controller) {
   function BaseController() {
     babelHelpers.classCallCheck(this, BaseController);
 
-    _Chaplin$Controller.call.apply(_Chaplin$Controller, [this].concat(babelHelpers.slice.call(arguments)));
+    _Chaplin$Controller.apply(this, arguments);
   }
 
   babelHelpers.inherits(BaseController, _Chaplin$Controller);
@@ -15,9 +15,9 @@ var BaseController2 = (function (_Chaplin$Controller$Another) {
   function BaseController2() {
     babelHelpers.classCallCheck(this, BaseController2);
 
-    _Chaplin$Controller$Another.call.apply(_Chaplin$Controller$Another, [this].concat(babelHelpers.slice.call(arguments)));
+    _Chaplin$Controller$Another.apply(this, arguments);
   }
 
   babelHelpers.inherits(BaseController2, _Chaplin$Controller$Another);
   return BaseController2;
-})(Chaplin.Controller.Another);
+})(Chaplin.Controller.Another);

test/core/fixtures/transformation/es6.classes-loose/super-class/expected.js

@@ -4,9 +4,9 @@ var Test = (function (_Foo) {
   function Test() {
     babelHelpers.classCallCheck(this, Test);
 
-    _Foo.call.apply(_Foo, [this].concat(babelHelpers.slice.call(arguments)));
+    _Foo.apply(this, arguments);
   }
 
   babelHelpers.inherits(Test, _Foo);
   return Test;
-})(Foo);
+})(Foo);

test/core/fixtures/transformation/es6.parameters.rest/async-function/actual.js

@@ -0,0 +1,7 @@
+var fn = async (...rest) => rest;
+
+var fn = async (...rest) => {
+  if (true) {
+    rest;
+  }
+};

test/core/fixtures/transformation/es6.parameters.rest/async-function/expected.js

@@ -0,0 +1,39 @@
+"use strict";
+
+var _this = this;
+
+var fn = function fn() {
+  for (var _len = arguments.length, rest = Array(_len), _key = 0; _key < _len; _key++) {
+    rest[_key] = arguments[_key];
+  }
+
+  return regeneratorRuntime.async(function fn$(context$1$0) {
+    while (1) switch (context$1$0.prev = context$1$0.next) {
+      case 0:
+        return context$1$0.abrupt("return", rest);
+
+      case 1:
+      case "end":
+        return context$1$0.stop();
+    }
+  }, null, _this);
+};
+
+var fn = function fn() {
+  for (var _len2 = arguments.length, rest = Array(_len2), _key2 = 0; _key2 < _len2; _key2++) {
+    rest[_key2] = arguments[_key2];
+  }
+
+  return regeneratorRuntime.async(function fn$(context$1$0) {
+    while (1) switch (context$1$0.prev = context$1$0.next) {
+      case 0:
+        if (true) {
+          rest;
+        }
+
+      case 1:
+      case "end":
+        return context$1$0.stop();
+    }
+  }, null, _this);
+};

test/core/fixtures/transformation/es6.parameters.rest/async-function/options.json

@@ -0,0 +1,3 @@
+{
+  "stage": 0
+}

test/core/fixtures/transformation/es6.parameters.rest/deepest-common-ancestor-earliest-child/actual.js

@@ -41,3 +41,12 @@ function r(...rest){
   if (lol) rest;
   rest;
 }
+
+// nested functions
+function a(...args) {
+  return function() {
+    function b() {}
+
+    console.log("Shouldn't args be from a's scope?", args);
+  };
+}

test/core/fixtures/transformation/es6.parameters.rest/deepest-common-ancestor-earliest-child/expected.js

@@ -64,3 +64,16 @@ function r() {
   if (lol) rest;
   rest;
 }
+
+// nested functions
+function a() {
+  for (var _len6 = arguments.length, args = Array(_len6), _key6 = 0; _key6 < _len6; _key6++) {
+    args[_key6] = arguments[_key6];
+  }
+
+  return function () {
+    function b() {}
+
+    console.log("Shouldn't args be from a's scope?", args);
+  };
+}

test/core/fixtures/transformation/es6.parameters.rest/spread-optimisation/actual.js

@@ -13,3 +13,8 @@ function foo(a, ...b) {
 function foo(...b) {
   foo(1, ...b);
 }
+
+function foo(...args){
+  args.pop()
+  foo(...args);
+}

test/core/fixtures/transformation/es6.parameters.rest/spread-optimisation/expected.js

@@ -23,3 +23,12 @@ function foo() {
 
   foo.apply(undefined, [1].concat(b));
 }
+
+function foo() {
+  for (var _len3 = arguments.length, args = Array(_len3), _key3 = 0; _key3 < _len3; _key3++) {
+    args[_key3] = arguments[_key3];
+  }
+
+  args.pop();
+  foo.apply(undefined, args);
+}