miel.truyen/nx
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

fix(graph): fix empty target group (#26704)

Browse Source 
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->
![Screenshot 2024-06-26 at 2 56
04 PM](https://github.com/nrwl/nx/assets/16211801/d9cc93db-06a2-4c30-b88a-3054edfb619a)

when the others group are empty, it shows the container.
move the check to
graph/ui-project-details/src/lib/target-configuration-details-group-container/target-configuration-details-group-container.tsx.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
This commit is contained in:
Emily Xiong 2024-06-27 08:51:43 -07:00 committed by GitHub
parent 4197a91845
commit 5e022951da
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
graph/ui-project-details/src/lib/target-configuration-details-group-container/target-configuration-details-group-container.tsx
View File

@ -17,6 +17,9 @@ export function TargetConfigurationGroupContainer({
nxConnectCallback, nxConnectCallback,
children, children,
}: TargetConfigurationGroupContainerProps) { }: TargetConfigurationGroupContainerProps) {
if (targetsNumber === 0) {
return null;
}
return ( return (
<div className="mb-4 w-full"> <div className="mb-4 w-full">
<TargetConfigurationGroupHeader <TargetConfigurationGroupHeader

3
graph/ui-project-details/src/lib/target-configuration-details-group-list/target-configuration-details-group-list.tsx
View File

@ -47,9 +47,6 @@ export function TargetConfigurationGroupList({
<> <>
{Object.entries(targetsGroup.groups).map( {Object.entries(targetsGroup.groups).map(
([targetGroupName, targets]) => { ([targetGroupName, targets]) => {
if (targets.length === 0) {
return null;
}
return ( return (
<TargetConfigurationGroupContainer <TargetConfigurationGroupContainer
targetGroupName={targetGroupName} targetGroupName={targetGroupName}